[sheepdog] [PATCH V4 2/2] collie: optimize 'collie vdi check' command

[Yunkai Zhang]

On Tue, Sep 4, 2012 at 12:44 PM, Liu Yuan <namei.unix at gmail.com> wrote:
> On 09/04/2012 12:19 PM, MORITA Kazutaka wrote:
>> Yuan said that he didn't want to move sha1_to_hex to lib/sha1.c, so I
>> won't be against it any more if he is okay...
>
> I don't want comment on this patch set any more, but seems that if I
> don't speak, there is dead lock. For now I only talk about movement
> sha1_to_hex to lib/sha1.c, not related about patch set at all.
>
> Please don't move sha1_to_hex() to lib/sha1.c, it is only farm related
> and I don't think we should expose this detail outside. If you need it,
> please write it directly in collie.

This is really too hard to understand!

I give up this patchset.

And I'm afraid my new code would bother someone when it need to move
whatever functions, I'm not going to send any patch to here in a short
term.

>
> Thanks,
> Yuan



-- 
Yunkai Zhang
Work at Taobao