[sheepdog] [PATCH 1/4] sheep: don't send unnecessary data against read requests

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Mon Sep 10 11:54:12 CEST 2012


At Mon, 10 Sep 2012 11:29:25 +0800,
Liu Yuan wrote:
> 
> On 09/10/2012 12:13 AM, MORITA Kazutaka wrote:
> > req->rp.data_length = 0;
> 
> instead of playing with data_length, can we check rsp->rp.result in
> do_client_tx() before transmitting?

I've also tried it, but it couldn't work.  A SD_OP_STAT_CLUSTER
request needs to receive epoch data even when the result is not
SD_RES_SUCCESS.  Although This patch looks a bit complicated, we
should explicitly specify the length of response data when the request
type is not SD_FLAG_CMD_WRITE, I think.

Thanks,

Kazutaka



More information about the sheepdog mailing list