[sheepdog] [PATCH 3/4] sheep: add support for manual recovery

[MORITA Kazutaka]

At Tue, 11 Sep 2012 17:07:51 +0800,
Liu Yuan wrote:
> 
> On 09/11/2012 04:25 PM, MORITA Kazutaka wrote:
> > +	if (sys->disable_recovery && rw->nr_scheduled_prio_oids <= rw->done) {
> 
> I guess we'd better add a inline helper here to be more
> self-explanatory, because rw->nr_scheduled_prio_oids <= rw->done is key
> to the lazy recovery logic.
> 
> how about
> 
> /* Document how lazy recovery work a bit */
> bool has_objects_scheduled(struct recovery_work *rw)
> ...
> 
> if (sys->disable_recovery && has_objects_scheduled(rw))
> ...

Looks good, I'll send a v2.

Thanks,

Kazutaka