[sheepdog] [PATCH] Add command line option for binding to a specified interface.

[MORITA Kazutaka]

At Fri, 28 Sep 2012 08:42:13 -0700,
Bryan D. Payne wrote:
> 
> > Nice work, but this patch has many style problems.  Can you run
> > ./script/checkpatch.pl and fix the errors?
> 
> Here's the output that I see from that tool.  The one warning appears
> to be a false positive as the other code defining command line
> parameters is formatted exactly the same as my patch.  Are you seeing
> different output.  What would you like for me to change in the patch
> formatting?

Here is the output.  Perhaps, your mailer replaced tabs with white
spaces?

==
ERROR: code indent should use tabs where possible
#119: FILE: include/net.h:48:
+                       int (*callback)(int fd, void *), void *data);$

WARNING: please, no spaces at the start of a line
#119: FILE: include/net.h:48:
+                       int (*callback)(int fd, void *), void *data);$

ERROR: patch seems to be corrupt (line wrapped?)
#128: FILE: lib/net.c:112:
conn_state next_state, int flags)

[..snip..]

total: 15 errors, 23 warnings, 112 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

patches/1.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.