[sheepdog] [PATCH v2 6/7] sheep: remove duplicate recovery complete notification
MORITA Kazutaka
morita.kazutaka at lab.ntt.co.jp
Wed Apr 3 04:10:05 CEST 2013
At Fri, 29 Mar 2013 13:49:43 +0800,
Liu Yuan wrote:
>
> From: Liu Yuan <tailai.ly at taobao.com>
>
> Signed-off-by: Liu Yuan <tailai.ly at taobao.com>
> ---
> sheep/ops.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/sheep/ops.c b/sheep/ops.c
> index 3839437..204befd 100644
> --- a/sheep/ops.c
> +++ b/sheep/ops.c
> @@ -624,7 +624,19 @@ static int cluster_recovery_completion(const struct sd_req *req,
> nr_recovereds = 0;
> }
>
> - recovereds[nr_recovereds++] = *(struct sd_node *)node;
> + /*
> + * Disk failure might send duplicate notication, ingore it.
notification, ignore
> + *
> + * We can't simply stop disk recovery from sending notication because
notification
> + * disk recovery might supersed node recovery, which indeed need
supersede?
> + * to send notication
notification
Thanks,
Kazutaka
More information about the sheepdog
mailing list