[sheepdog] [PATCH v3 4/7] sheep: use new journal API for config file

Hitoshi Mitake mitake.hitoshi at gmail.com
Fri Apr 5 10:47:24 CEST 2013


At Thu,  4 Apr 2013 20:49:39 +0800,
Liu Yuan wrote:

> +	/* We should init journal file before config file init */
> +	if (uatomic_is_true(&sys->use_journal)) {
> +		if (!strlen(jpath))
> +			/* internal journal */
> +			memcpy(jpath, dir, strlen(dir));
> +		sd_dprintf("%s, %zu, %d", jpath, jsize, jskip);
> +		ret = journal_file_init(jpath, jsize, jskip);
> +		if (ret)
> +			exit(1);
> +	}

Current sheep always requires the arguments of -j. If no argument
successes after -j, the command line is treated as an invalid thing.

But I think that -j with no arguments should be accepted. jpath,
jsize, jskip should have default values in such a case.

Thanks,
Hitshi



More information about the sheepdog mailing list