[sheepdog] [PATCH v3 4/7] sheep: use new journal API for config file

Hitoshi Mitake mitake.hitoshi at gmail.com
Fri Apr 5 11:31:08 CEST 2013


At Fri, 05 Apr 2013 17:19:23 +0800,
Liu Yuan wrote:
> 
> On 04/05/2013 04:55 PM, Hitoshi Mitake wrote:
> > But the journaling is not default now. Until it becomes default, I
> > think -j with no arguments should be supoprted. In typical cases, the
> > default values are suitable.
> 
> Nope. The real problem is which value do you think is best default one?
> You can't find a default values for all cases. Bigger value means
> wasteful and smalling value means degraded performance.

I assumed MIN_JOURNAL_SIZE as a default size of journal files.

> 
> Let's keep it as is. '-j' no option isn't a must to add.

OK, let's keep it as is. But I think we should find the suitable default
size if the journaling becomes default even if the value is based on
heuristics. Or at least we have to prepare a guideline for determining
the size.

Thanks,
Hitoshi



More information about the sheepdog mailing list