[sheepdog] [PATCH 5/7 v4 UPDATE] sheep: rename journal_file.c as journal.c

Hitoshi Mitake mitake.hitoshi at gmail.com
Fri Apr 5 11:40:57 CEST 2013


At Fri, 05 Apr 2013 17:36:09 +0800,
Liu Yuan wrote:
> 
> On 04/05/2013 04:51 PM, Hitoshi Mitake wrote:
> > do_recover should return here if a condition st.st_size == 0 is true.
> > If st.st_size == 0, the below mmap() fails with Invalid argument.
> 
> if st.st_size == 0, then error handling of mmap() will return by
> 
>         if (map == MAP_FAILED) {
>                 sd_eprintf("%m");
>                 return -1;
>         }
> 
> no?

Yes. the condition will be true and -1 is returned. And the return
value causes an error of journal_file_init() called by main(). The
error stops initialization process of sheep. Actually, I couldn't
launch sheep process with this reason.

The problem is that zero-sized journal files are valid things and they
can stop initialization of sheeps.

Thanks,
Hitoshi






More information about the sheepdog mailing list