[sheepdog] [PATCH] sheep: clean up SD_RES_xxx macros

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Fri Apr 12 09:11:59 CEST 2013


At Fri, 12 Apr 2013 15:04:34 +0800,
Liu Yuan wrote:
> 
> On 04/12/2013 03:01 PM, MORITA Kazutaka wrote:
> > Why don't you move SD_OP_xxx for collie to sheepdog_proto.h?  I'd like
> > to see the reason in the commit log.
> 
> The reason is that if we move SD_OP_xxx for collie into
> sheepdog_proto.h, then when we add a new protocol between QEMU and
> sheep, the numbering will look odds, a gap that collie holds but QEMU
> will never see. It is kind of hard to maintain QEMU block driver.
> 
> If you agree, I'll update the commit log with above comment.

Agreed.

Thanks,

Kazutaka



More information about the sheepdog mailing list