[sheepdog] [PATCH v2 1/2] sheep: teach sheep to discard unused objects

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Tue Apr 16 05:43:44 CEST 2013


At Tue, 16 Apr 2013 11:35:48 +0800,
Liu Yuan wrote:
> 
> On 04/16/2013 11:33 AM, MORITA Kazutaka wrote:
> > This causes a compile error.
> > 
> >   CC     ops.o
> > Built sheep
> > ops.c: In function ‘local_discard_obj’:
> > ops.c:752: error: too few arguments to function ‘write_object’
> 
> Make clean? I don't have this error.

Oops, I forgot to apply your patch "sheep: remove unused 'flags' in
remove_object()" to my local tree.  But then,

>        ret = write_object(vid_to_vdi_oid(vid), (char *)&zero, sizeof(zero),
>                            SD_INODE_HEADER_SIZE + sizeof(vid) * idx, 0, cp);

the 5th argument should be false, not 0.

Thanks,

Kazutaka



More information about the sheepdog mailing list