[sheepdog] [PATCH 2/3] util:add a new API atomic_create_and_write()

Liu Yuan namei.unix at gmail.com
Wed Apr 17 07:55:09 CEST 2013

On 04/17/2013 01:45 PM, Hitoshi Mitake wrote:
> +	if (!access(tmp_path, F_OK))
> +		panic("temporal file: %s exists, this implies invalid usage of"
> +			" atomic_create_and_write() of sheepdog", tmp_path);

panic() is too stringent and not necessary. open(2) will return error if
it has any problem with the tmp_path. So I'd suggest remove this if clause.


More information about the sheepdog mailing list