[sheepdog] [PATCH 3/3] sheepdog: resend write requests when SD_RES_READONLY is received

Liu Yuan namei.unix at gmail.com
Thu Apr 25 15:08:01 CEST 2013

On 04/25/2013 06:37 PM, MORITA Kazutaka wrote:
> +/* update inode with the latest state */
> +static int coroutine_fn reload_vdi_object(BDRVSheepdogState *s)

I'd suggest function name as
'reload_inode(BDRVSheepdogState *s, tag, snapid)', then sd_create_branch
and sd_snapshot_goto can make use of this function. With this change, it
would be conflicted to my patch series applied to Stefan's block tree +
Fix loadvm patch. So it would be better you can develop this patch set
against Stefan's block tree + my fix loadvm patch.

Others looks good to me.


More information about the sheepdog mailing list