[sheepdog] [PATCH] recovery: fix incomplete recovery because of faulty oid scheduling

Liu Yuan namei.unix at gmail.com
Mon Apr 29 09:19:53 CEST 2013


On 04/29/2013 02:59 PM, MORITA Kazutaka wrote:
> Thanks, I understood what's going on from your log.
> 
> The problem is that scheduled oids can be re-scheduled again.  I think
> the following is a better fix because it also omits redundant
> scheduling even when auto-recovery is enabled.

Why better? If auto-recovery is enabled, we don't re-schedule on the
same oid. At least on the first oid.

Well, the real better fix is use two list, one for oids, and the other
for prio_oids. We should use red-black tree for this two lists for
better search performance. This was my plan but need much more codes so
I didn't do it.

Thanks,
Yuan



More information about the sheepdog mailing list