[sheepdog] [PATCH 4/6] sheep: add a helper to get vdi's inode

MORITA Kazutaka morita.kazutaka at gmail.com
Mon Apr 29 13:44:56 CEST 2013


At Mon, 29 Apr 2013 18:18:31 +0800,
Liu Yuan wrote:
> 
> On 04/29/2013 06:26 AM, MORITA Kazutaka wrote:
> > If we can safely read the inode from cache, please explain the reason
> > in the commit log.
> > 
> > Perhaps, vdi_get_inode() has to call read_backend_object() instead of
> > read_object()?
> 
> I'm not sure. Current object cache will be released after we shutdown
> VDI. so will be no problem to call read_object for deletion.

Sheep cannot read inode from the cache because post_cluster_del_vdi()
already removed it - I think this is the intention of Levin.  Removing
the cache after deleting all the relevant objects looks better to me,
though.

Thanks,

Kazutaka



More information about the sheepdog mailing list