[sheepdog] [PATCH 6/6] sheep: refactor start_deletion

MORITA Kazutaka morita.kazutaka at gmail.com
Mon Apr 29 13:53:13 CEST 2013

At Mon, 29 Apr 2013 18:22:34 +0800,
Liu Yuan wrote:
> On 04/29/2013 06:35 AM, MORITA Kazutaka wrote:
> > I think changing the order of these two functions makes it very hard
> > to review this patch.  Can you prepare another one to change this
> > order?
> You mean two different patches to squash each functions? these two
> functions as well as vdi_fill_list() are very closely related, can't
> squash one without modifying another.

I meant:
 1. Move fill_vdi_list() below get_vdi_root in the first patch.
 2. Do the other changes in the next patch.

I thought that this would make the patch much easier to read, but if
I'm wrong, I'll try to review the current version again.



More information about the sheepdog mailing list