[sheepdog] [PATCH RFC] employ gnu99 style of GCC

Hitoshi Mitake mitake.hitoshi at gmail.com
Mon Apr 29 17:18:39 CEST 2013


At Tue, 30 Apr 2013 00:08:28 +0900,
Hitoshi Mitake wrote:
> 2. Unnamed struct/union fields:
>    http://gcc.gnu.org/onlinedocs/gcc/Unnamed-Fields.html#Unnamed-Fields
>    With this feature, journal_write_store() and journal_write_epoch()
>    can be cleaner.

Sorry, the second is incorrect. The notation like this cause errors
even if -std=gnu99 is passed to gcc:
	struct journal_descriptor jd = {
		.magic = JOURNAL_DESC_MAGIC,
		.flag = JF_EPOCH,
		.epoch = epoch,
		.offset = 0,
		.size = size,
		.create = true,
	};

So we cannot count the second as a benefit.

Thanks,
Hitoshi



More information about the sheepdog mailing list