[sheepdog] [PATCH 01/14] Revert "test: collect logs of sheeps after tests"

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Tue Apr 30 10:29:56 CEST 2013

This reverts commit 26cdf0dee923ad16989ed22436692272af1a071a.

I iterate the check script many times everyday and can pass all the
test cases in most cases.  However, this patch generates a log.*
directory for each time even if there is no errors, and a large number
of log directories have been annoying me.  In addition, this collects
log files only of the last test, and does nothing against the other

Rather than improving this half baked patch, let's revert it for now
and reconsider the best way to collect logs.  IMHO collecting log
files should be done outside of the test scripts, though.

Cc: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
Signed-off-by: MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp>
 .gitignore  |  1 -
 tests/check | 18 ------------------
 2 files changed, 19 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8ef547b..60448d4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -61,6 +61,5 @@ tests/check.log
diff --git a/tests/check b/tests/check
index cfa157f..95c5a1d 100755
--- a/tests/check
+++ b/tests/check
@@ -532,24 +532,6 @@ do
-# collect log files
-log_dir=logs.`date +%Y-%m-%d-%H-%M-%S`
-if [ ! -d $log_dir ]
-    mkdir $log_dir
-    max_nr_sheeps=`find $STORE -name sheep.log | wc -l`
-    max_nr_sheeps=`expr $max_nr_sheeps - 1`
-    for i in `seq 0 $max_nr_sheeps`;
-    do
-	cp $STORE/$i/sheep.log $log_dir/$i.log
-    done
-    echo "directory $log_dir already exists"
-    echo "skip collecting log files"
 status=`expr $n_bad`

More information about the sheepdog mailing list