At Fri, 9 Aug 2013 11:08:52 +0800, Kai Zhang wrote: > > > On Aug 9, 2013, at 11:03 AM, MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp> wrote: > > > At Thu, 8 Aug 2013 19:41:33 -0700, > > Kai Zhang wrote: > >> > >> v2: > >> - add a patch to fixed wrong return code of zk_join > >> - reduce the interval of getting lock rety from 1s to 50ms > >> - fixed wrong calculation of queue_pos > >> > >> Kai Zhang (2): > >> zookeeper: zk_join() should return 0 on success and -1 on error > >> zookeeper: remove master from zookeeper > >> > >> sheep/cluster/zookeeper.c | 241 ++++++++++----------------------------------- > >> 1 file changed, 54 insertions(+), 187 deletions(-) > > > > I wonder if the second patch should go into the 0.7.0 release. The > > cleanup looks not trivial and, IMO, needs more tests. What do you > > think of it? > > > > If you have a enough time to test the zk driver before the 0.7.0 > > release, I'm happy to include the patch into the release. > > > > I agree. I think the second patch is not an important feature nor fixed any existing bug. > So I think the release of 0.7.0 should not depend on this patch. > If it is ready, we merge it. If not, we can merge it after 0.7.0. > What do you think? 0.7.0 is going to be released on 2013.8.15. Let's wait it. > > Anyway, I would like to do more test on it. Thanks a lot. Kazutaka |