[sheepdog] [PATCH v2 04/10] trace: add support for stackable tracers

MORITA Kazutaka morita.kazutaka at gmail.com
Fri Aug 9 10:35:22 CEST 2013


At Fri, 9 Aug 2013 12:47:58 +0800,
Liu Yuan wrote:
> 
> >  
> > -register_tracer(graph_tracer);
> > +static struct tracer graph_tracer = {
> > +	.name = "graph",
> > +
> > +	.enter = graph_tracer_enter,
> > +	.exit = graph_tracer_exit,
> > +};
> > +
> > +tracer_register(graph_tracer);
> 
> trace_register would be better since we use trace as namespace for trace
> functions

I think tracer_register is better.  What we want to register here is a
tracer.  We are using the name XXX_register() for constructors to
register XXX (e.g. cdrv_register, log_format_register).

Thanks,

Kazutaka



More information about the sheepdog mailing list