[sheepdog] [PATCH 4/4] dog: make repairing vdi optional

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Thu Aug 22 09:20:42 CEST 2013


At Thu, 22 Aug 2013 15:12:58 +0800,
Liu Yuan wrote:
> > 
> > E.g.
> > 
> >   dog vdi check existence      # existence check
> >   dog vdi check consistency    # consistency check
> >   dog vdi check relation       # snapshot relation check
> >   dog vdi check inode          # inode coruption check
> >   dog vdi check all            # full check
> > 
> 
> Above looks better.
> 
> > and '-A' means auto-repair.
> 
> I don't understand why we need '-A'. Does it mean 'yes' to all confirm? Do people
> in any cases answer no? I think auto-repair isn't necessary. We should repair
> the problems we found automatically for easy use.

I think it's pretty common that auto-repair is disable by default
(e.g. fsck), and I guess user doesn't expect the command will do
repair too.  In addition, if auto-repair is disabled, 'check relation'
and 'check inode' can be run even when the vm is using the image.

Thanks,

Kazutaka



More information about the sheepdog mailing list