[sheepdog] [PATCH 4/4] dog: make repairing vdi optional

[Liu Yuan]

On Thu, Aug 22, 2013 at 09:30:05AM +0200, Valerio Pachera wrote:
> Sorry guys if I intrude in this list.
> 
> In my opinion, form user point of view, it would be nice to have a
> "read only" check that could be run with a running vm.
> In case problems are reported, then the user could shutdown the guest
> when he can, and run the check "read write" (auto repair).
> 
> Similar to
> xfs_check -n <device>  (no repair)
> xfs_check <device> (repair)
> 

This looks reasonable to me.

> From user point of view, existence/inode/consistency/relation, maxes
> no difference.
> You may create such sub command but keep them "hidden" for developer
> use or advanced diagnostic.
> 
> This is only to give my point of view, but do what you consider best
> for the project.

I think of following interface to user:

vdi check image # check any possible wrong and report to user
vdi check -r image # repair the image as hard as it can

And
vdi check image [-r -o {options,list}] for advanced users.

Thanks
Yuan