[sheepdog] [PATCH 4/4] dog: make repairing vdi optional

[MORITA Kazutaka]

At Thu, 22 Aug 2013 15:30:33 +0800,
Liu Yuan wrote:
> 
> On Thu, Aug 22, 2013 at 04:20:42PM +0900, MORITA Kazutaka wrote:
> > At Thu, 22 Aug 2013 15:12:58 +0800,
> > Liu Yuan wrote:
> > > > 
> > > > E.g.
> > > > 
> > > >   dog vdi check existence      # existence check
> > > >   dog vdi check consistency    # consistency check
> > > >   dog vdi check relation       # snapshot relation check
> > > >   dog vdi check inode          # inode coruption check
> > > >   dog vdi check all            # full check
> > > > 
> > > 
> > > Above looks better.
> > > 
> > > > and '-A' means auto-repair.
> > > 
> > > I don't understand why we need '-A'. Does it mean 'yes' to all confirm? Do people
> > > in any cases answer no? I think auto-repair isn't necessary. We should repair
> > > the problems we found automatically for easy use.
> > 
> > I think it's pretty common that auto-repair is disable by default
> > (e.g. fsck), and I guess user doesn't expect the command will do
> > repair too.  In addition, if auto-repair is disabled, 'check relation'
> > and 'check inode' can be run even when the vm is using the image.
> 
> Is there any case that people run 'vdi check' against running vm? I think we

Actually, we do it.  We plan to do health check everyday to make sure
that sheepdog is running correctly, and the similar feature is one of
necessary things for storage system.

Thanks,

Kazutaka