[sheepdog] [PATCH 1/3] use fcntl to set FD_CLOSEXEC instead of type "e" in popen()

Liu Yuan namei.unix at gmail.com
Fri Aug 23 06:23:03 CEST 2013


On Thu, Aug 22, 2013 at 05:51:01PM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai at taobao.com>
> 
> In glibc < 2.9 environment (rhel5), it dose not support type "e" in popen(), so
> we should replace it by calling fcntl(xxx, FD_CLOSEXEC).
> 
> If pass NULL into pclose(), it would make program coredump, therefore add check
> for argument.
> 
> Signed-off-by: Robin Dong <sanbai at taobao.com>

patch 1 and 3 applied, thanks

Yuan



More information about the sheepdog mailing list