[sheepdog] [PATCH] recovery: free recovery info before stopping recovery

MORITA Kazutaka morita.kazutaka at gmail.com
Mon Aug 26 13:07:05 CEST 2013


At Mon, 26 Aug 2013 17:11:50 +0800,
Liu Yuan wrote:
> 
> On Mon, Aug 26, 2013 at 06:07:00PM +0900, MORITA Kazutaka wrote:
> > From: MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp>
> > 
> > Without this patch, the recovery thread cannot start the next recovery
> > and the stopped recovery cannot start any more.
> > 
> > Signed-off-by: MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp>
> > ---
> > 
> > I think this should go into the stable branch, too.
> > 
> >  sheep/recovery.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/sheep/recovery.c b/sheep/recovery.c
> > index e734b88..c63f416 100644
> > --- a/sheep/recovery.c
> > +++ b/sheep/recovery.c
> > @@ -611,7 +611,8 @@ static void recover_object_main(struct work *work)
> >  		 * lifted and flush wait queue to requeue those
> >  		 * requests
> >  		 */
> > -		wakeup_all_requests();
> 
> any reason you remove this line?

It is called in finish_recovery().

Thanks,

Kazutaka



More information about the sheepdog mailing list