[sheepdog] [PATCH v5 0/2] dog: repair objects based on majority vote

Hitoshi Mitake mitake.hitoshi at gmail.com
Thu Dec 12 03:22:52 CET 2013


At Tue, 12 Nov 2013 11:09:03 +0800,
Liu Yuan wrote:
> 
> On Tue, Nov 12, 2013 at 11:45:23AM +0900, Hitoshi Mitake wrote:
> > Current object repair strategy of "dog vdi check" doesn't work well if
> > objects are corrupted. The first one adds a test for the case, and the
> > second patch adds a mechanism for majority voting in the command.
> > 
> > v5: drop ignore change in v4
> 
> Applied after fixing new blank line at EOF for 077
> 
> I'd like to see patche(s) that deal with the case when majority object isn't
> found. What in my head to deal with this is:
> 
> - add an option 'depth' for 'dog vdi track' command to get the information of
> targeted object placement.
> 
> With this information, people can do a manual copy\overwrite to missing/inconsistent
> objects.

On the second thought, I think we don't need the option "depth" for
vdi tracking. Because printing node lists is not expensive and entire
log wouldn't be an annoying thing (tail of output is a latest epoch).

Instead of "depth", I'd like to add a new option "oid". With this
option, users can track an object with its id. This would be more
friendly for users because output of vdi repair is based on oid, not
index.

I'll post the patch soon.

Thanks,
Hitoshi



More information about the sheepdog mailing list