[sheepdog] Fwd: [Bug 1261941] [NEW] creating sheepdog volume from image fails

[Hitoshi Mitake]

Hi Joe,

Thanks a lot for your report and patch. I'm not familiar with cinder's
development process, so I'm forwarding this email to the maintainers
of cinder's sheepdog driver.

Could you help review Joe's patch, Yuan or Kazutaka-san?


---------- Forwarded message ----------
From: Joe Rouvier <joe at rouvier.org>
Date: Wed, Dec 18, 2013 at 7:00 AM
Subject: [Bug 1261941] [NEW] creating sheepdog volume from image fails
To: mitake.hitoshi at gmail.com


Public bug reported:

When sheepdog is the backend, attempts to create a volume from an image
fail with the error:

cinder.volume.flows.create_volume [req-AAAAA BBBBB] Failed to copy image
CCCCC to volume: DDDD, error: qemu-img: Could not open '<open GreenPipe
'<fd:12>', mode 'w+b' at 0x35d6ef0>': No such file or directory

This would be corrected by the following change:

index 21bda61..1168a60 100644
--- a/cinder/volume/drivers/sheepdog.py
+++ b/cinder/volume/drivers/sheepdog.py
@@ -112,7 +112,7 @@ class SheepdogDriver(driver.VolumeDriver):
             # see volume/drivers/manager.py:_create_volume
             self._delete(volume)
             # convert and store into sheepdog
-            image_utils.convert_image(tmp.name, 'sheepdog:%s' % volume['name'],
+            image_utils.convert_image(tmp, 'sheepdog:%s' % volume['name'],
                                       'raw')
             self._resize(volume)

** Affects: cinder
     Importance: Undecided
         Status: New

** Affects: sheepdog-project
     Importance: Undecided
         Status: New

--
You received this bug notification because you are subscribed to Cinder.
Matching subscriptions: cinder-bug
https://bugs.launchpad.net/bugs/1261941

Title:
  creating sheepdog volume from image fails

Status in Cinder:
  New
Status in sheepdog-project:
  New

Bug description:
  When sheepdog is the backend, attempts to create a volume from an
  image fail with the error:

  cinder.volume.flows.create_volume [req-AAAAA BBBBB] Failed to copy
  image CCCCC to volume: DDDD, error: qemu-img: Could not open '<open
  GreenPipe '<fd:12>', mode 'w+b' at 0x35d6ef0>': No such file or
  directory

  This would be corrected by the following change:

  index 21bda61..1168a60 100644
  --- a/cinder/volume/drivers/sheepdog.py
  +++ b/cinder/volume/drivers/sheepdog.py
  @@ -112,7 +112,7 @@ class SheepdogDriver(driver.VolumeDriver):
               # see volume/drivers/manager.py:_create_volume
               self._delete(volume)
               # convert and store into sheepdog
  -            image_utils.convert_image(tmp.name, 'sheepdog:%s' %
volume['name'],
  +            image_utils.convert_image(tmp, 'sheepdog:%s' % volume['name'],
                                         'raw')
               self._resize(volume)

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1261941/+subscriptions