[sheepdog] [PATCH 1/2] sheep: introduce strict mode for write

Liu Yuan namei.unix at gmail.com
Wed Dec 11 04:05:58 CET 2013


On Wed, Dec 11, 2013 at 10:59:27AM +0800, Robin Dong wrote:
> Why not adding the check in gateway_forward_request() ? I think we should
> check the copy number before send forward the request out.

I think it is better to check the request as early as possible, no? This is
pointless to run the request down to gateway_forward_request(), which is queued
on the work queue and might need some time to be called and then return the
error to the client.

What is the benefit to check inside the gateway_forward_request instead of the
approch of this patch?

Thanks
Yuan



More information about the sheepdog mailing list