[sheepdog] [PATCH] sheep: add an option for selecting the output directory of sheep.log

Teruaki Ishizaki tell.ishi at gmail.com
Wed Dec 11 04:50:57 CET 2013


2013/12/11 Liu Yuan <namei.unix at gmail.com>:
> On Wed, Dec 11, 2013 at 10:31:54AM +0900, Ryusuke Konishi wrote:
>> On Wed, 11 Dec 2013 10:22:05 +0900, Hitoshi Mitake wrote:
>> > At Tue, 10 Dec 2013 12:36:06 +0800,
>> > Liu Yuan wrote:
>> >>
>> >> On Mon, Dec 09, 2013 at 08:49:45PM +0900, Teruaki Ishizaki wrote:
>> >> > Previously sheep.log was saved in the Sheepdog store directory,
>> >> > and used size of Sheepdog store directory included log file size.
>> >> > So, administrator couldn't do capacity planning simply.
>> >> >
>> >> > This patch adds an option for setting the output directory of sheep.log.
>> >> >
>> >> > Usage:
>> >> >  $ sheep -L dir=<log_output_dir>
>> >> >
>> >> > Example:
>> >> >  $ sheep -L dir=/logdir /datastore
>> >>
>> >> I think it is a good time to group logger parameters into a single option, that
>> >> is
>> >>
>> >>  -l level=xxx,dir=yyy,formatter=zzz.
>> >
>> > I think this patch is helpful for administrators so I want to backport
>> > it to stable-0.7. I want a patch for grouping the logger parameters to
>> > be an independent one for minimizing interface change of the stable
>> > branch.
>>
>> So, How about separating this change to two patches?
>>
>> - The first patch simply adds log directory option, and then backport
>>   it for stable users.
>>
>> - The second patch refactors the log option as above for future releases.
>>
>
> Looks good to me
>

ok, I'll send two patches.

Thanks,
Teruaki



More information about the sheepdog mailing list