[sheepdog] [PATCH] sheep: use valloc() for request buffer

Hitoshi Mitake mitake.hitoshi at gmail.com
Tue Dec 17 16:54:48 CET 2013


At Tue, 17 Dec 2013 23:47:59 +0800,
Liu Yuan wrote:
> 
> Dec 17 23:38:30  ERROR [gway 5442] default_read_from_path(287) failed to read object 7c2b2500000000, path=/tmp/store/0/obj/007c2b2500000000, offset=0, size=4194304, result=-1, Invalid argument
> Dec 17 23:38:30  ERROR [gway 5442] err_to_sderr(115) oid=7c2b2500000000, Invalid argument
> Dec 17 23:38:30  ERROR [gway 5442] gateway_replication_read(294) local read 7c2b2500000000 failed, Network error between sheep
> 
> This bug is triggered when we start sheep with '-D' option (derectio) because
> request buffer isn't page aligned.
> 
> Signed-off-by: Liu Yuan <namei.unix at gmail.com>
> ---
>  sheep/gateway.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks good to me.
Reviewed-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>

Thanks,
Hitoshi



More information about the sheepdog mailing list