[sheepdog] [PATCH] dog: initialize a reference count of check/repair work correctly

Hitoshi Mitake mitake.hitoshi at gmail.com
Thu Dec 19 05:39:09 CET 2013


At Thu, 19 Dec 2013 10:28:11 +0900,
Hitoshi Mitake wrote:
> 
> At Wed, 18 Dec 2013 20:12:58 +0900,
> Hitoshi Mitake wrote:
> > 
> > At Wed, 18 Dec 2013 17:21:23 +0800,
> > Liu Yuan wrote:
> > > 
> > > On Wed, Dec 18, 2013 at 05:50:35PM +0900, Hitoshi Mitake wrote:
> > > > Current dog initializes a reference count of check/repair work in an
> > > > invalid way. This patch fixes it.
> > > 
> > > Could you add a test to make sure we won't make the same mistake?
> > 
> > We can't write an effective test for this problem because:
> > 
> > 1. it comes from non determinism of multi threading
> > 2. vdi progress bar is invisible when "dog vdi check" is invoked by scripts
> > 
> 
> Could you push the patch to the master branch, Yuan?

ping?

Thanks,
Hitoshi



More information about the sheepdog mailing list