[sheepdog] [PATCH 1/2] sheep: introduce strict mode for write

[Hitoshi Mitake]

At Fri, 13 Dec 2013 05:41:03 +0900,
MORITA Kazutaka wrote:
> 
> At Thu, 12 Dec 2013 14:37:23 +0800,
> Liu Yuan wrote:
> > 
> > > > 
> > > > Ah, yes. I think SD_FLAG_CMD_WRITE is kind of misleading (couple of times I
> > > > forgot to assigne it while write something and spent time debugging it)
> > > 
> > > I think so too. hdr.data_length != 0 may have same meaning to the
> > > flag. It can be removed.
> > 
> > But read has data_length != 0 too. I am wondering if SD_OP_{CREATE, WRITE}
> > is good enough to indicate that this request has something to carry. Thus
> > this flag can be removed.
> 
> We discussed the same thing before and I'm still against regarding
> SD_OP_{CREATE, WRITE} as special ones.
> 
> I have a patch to add SD_FLAG_CMD_WRITE automatically, but it needs a
> lot of work for rebasing.  I think I can take some time for it within
> this year.  If you guys are fine with waiting another couples of
> weeks, I'm happy to complete the work.

Of course I can wait. I'm looking forward to seeing the patch.

Thanks,
Hitoshi