[sheepdog] [PATCH] sheep: cleaning vdi deletion process of sheep daemon

Hitoshi Mitake mitake.hitoshi at gmail.com
Thu Dec 26 08:11:25 CET 2013


At Thu, 26 Dec 2013 14:59:33 +0800,
Liu Yuan wrote:
> 
> [1  <multipart/alternative (7bit)>]
> [1.1  <text/plain; UTF-8 (quoted-printable)>]
> this is core chang, it would be nice if you can describe current delete
> algorithm and your new approach, what it solves, pros and cons
> 

This patch doesn't change the algorithm of VDI deletion. The biggest
difference is described in the comment of the below part.

> > +
> > +       /*
> > +        * the event fd is written by delete_one_vdi_done(), when all vdis
> > of
> > +        * deletion_info are deleted
> > +        */
> > +       eventfd_xread(di->finish_fd);
> >
> >         return ret;
> >  out:
...

Because of this synchronous eventfd_xread(), the operation of vdi
deletion never ends before actual completion. I think the above
comment is enough for the description. If you think it isn't enough,
I'll add more comments.

Thanks,
Hitoshi



More information about the sheepdog mailing list