[sheepdog] [PATCH] sheep: cleaning vdi deletion process of sheep daemon

Hitoshi Mitake mitake.hitoshi at gmail.com
Fri Dec 27 06:46:47 CET 2013


At Fri, 27 Dec 2013 13:41:29 +0800,
Robin Dong wrote:
> 
> [1  <multipart/alternative (7bit)>]
> [1.1  <text/plain; ISO-8859-1 (7bit)>]
> 2013/12/27 Liu Yuan <namei.unix at gmail.com>
> 
> > On Thu, Dec 26, 2013 at 03:53:51PM +0900, Hitoshi Mitake wrote:
> > > Current code of vdi deletion process in sheep deamon is a real
> > > disaster. Especially, its irregular usage of work queue is terrible
> > > thing for maintenance. In addition, the vdi deletion process can
> > > potentially notify a completion of deletion to a dog process before
> > > actual completion.
> > >
> > > This patch cleans the VDI deletion code and removes the above bug.
> >
> > Does this patch support hyper volume? I didn't find code dealing with hyper
> > volume
> >
> 
> Hi Yuan,
> 
> I will add delete-operation for hyper volume after  Hitoshi's patch be
> applied.

Isn't the delete operation implemented? It seems that it is already
implemented in the commit fc3d74647192.

Thanks,
Hitoshi



More information about the sheepdog mailing list