[sheepdog] [PATCH] dog: log dog operation in syslog

[Hitoshi Mitake]

At Fri, 27 Dec 2013 14:49:09 +0800,
Liu Yuan wrote:
> 
> On Fri, Dec 27, 2013 at 03:21:32PM +0900, Hitoshi Mitake wrote:
> > At Fri, 27 Dec 2013 13:29:16 +0800,
> > Liu Yuan wrote:
> > > 
> > > On Fri, Dec 27, 2013 at 02:18:31PM +0900, Hitoshi Mitake wrote:
> > > > At Fri, 27 Dec 2013 12:52:21 +0800,
> > > > Liu Yuan wrote:
> > > > > 
> > > > > On Fri, Dec 27, 2013 at 11:01:40AM +0900, Hitoshi Mitake wrote:
> > > > > > This patch is based on a request from our internal team. Currently,
> > > > > > sheepdog doesn't provide a way of logging admin's operation. The lack
> > > > > > of this feature is serious because we cannot find any evidence of
> > > > > > operation.
> > > > > > 
> > > > > > This patch adds the logging feature in dog command. If the environment
> > > > > > variable, SHEEPDOG_DOG_LOG, has value, dog command logs its command
> > > > > > line argument with syslog.
> > > > > 
> > > > > syslog is full of logs unrelated to sheepdog. How about a dedicated log file
> > > > > e.g, /var/log/sheepdog/dog.log to log the dog operation? SHEEPDOG_DOG_LOG can
> > > > > be used as a hint for user defined locatin for log file. I'd like to make loging
> > > > > of dog operation default on.
> > > > 
> > > > A dedicated log file should be supported by dog, too. But current
> > > > standard syslog should also be supported. Some users may use rsyslog,
> > > > etc and sheepdog should fit into their way.
> > > > 
> > > > I'll implement the custom log location soon. Could you apply this one
> > > > first? 
> > > 
> > > Let's make it as simple as possible. Support both syslog and dedicated log file
> > > look unnecessary to me. One log file is good enough.
> > 
> > No, supporting both of them is necessary. Sheepdog should fit in
> > existing logging conventions of deployed environments. Some users want
> > sheep and dog to produce logs in a standard way (at least our internal
> > team wants). So we should support the way.
> 
> Okay, but I want to see the full patch set that support both syslog and user
> defined location before merging it. Then I'll have a vantage view of the whole
> picture.

OK, I'll send v2 later.

Thanks,
Hitoshi