[sheepdog] [PATCH] sheep, logger: select log formatter before log_init()

Hitoshi Mitake mitake.hitoshi at gmail.com
Fri Feb 1 07:58:12 CET 2013


At Fri, 01 Feb 2013 14:52:55 +0800,
Liu Yuan wrote:
> 
> On 02/01/2013 02:41 PM, Hitoshi Mitake wrote:
> > +	if (!log_format_selected)
> > +		select_log_formatter("default");
> 
> I think log_format_selected isn't necessary. You can have one var
> log_formatter = "default"; and point it to another user defined string
> if '-F' is specified. Then call select_log_formatter unconditionally.
> 

Ah, I agree. It seems to be a simpler way.
I'll send the v2 later.

Thanks,
Hitoshi



More information about the sheepdog mailing list