[sheepdog] [libvirt] Fix bugs of Sheepdog storage driver

harryxiyou harryxiyou at gmail.com
Thu Feb 7 17:32:59 CET 2013


On Thu, Feb 7, 2013 at 12:54 AM, Daniel P. Berrange <berrange at redhat.com> wrote:
> On Thu, Feb 07, 2013 at 12:52:36AM +0800, harryxiyou at gmail.com wrote:
>> ---
>>  src/storage/storage_backend_sheepdog.c |    5 ++++-
>>  1 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c
>> index cd18f33..2cbfe01 100644
>> --- a/src/storage/storage_backend_sheepdog.c
>> +++ b/src/storage/storage_backend_sheepdog.c
>> @@ -168,9 +168,12 @@ virStorageBackendSheepdogCreateVol(virConnectPtr conn ATTRIBUTE_UNUSED,
>>      virCommandAddArgFormat(cmd, "%llu", vol->capacity);
>>      virStorageBackendSheepdogAddHostArg(cmd, pool);
>>      ret = virCommandRun(cmd, NULL);
>> +     if (ret < 0)
>> +        goto cleanup;
>
> You're using tabs in the source which is not allowed, hence this
> broken indentation. Please make sure to run 'make syntax-check'
> before submitting changes.
>

I will give a patch after 'make syntax-check'.

-- 
Thanks
Harry Wei



More information about the sheepdog mailing list