[sheepdog] [PATCH] sheep: check unknown join result in sd_join_handler()

Hitoshi Mitake mitake.hitoshi at gmail.com
Tue Feb 19 02:31:10 CET 2013


At Tue, 19 Feb 2013 00:20:14 +0800,
Liu Yuan wrote:
> 
> On 02/18/2013 05:02 PM, Hitoshi Mitake wrote:
> > +		/* this means sd_check_join_cb() is buggy */
> > +		sd_printf(SDOG_CRIT, "unknown cluster join result: %d\n",
> > +			result);
> > +		abort();
> > +		break;
> 
> Then why not using panic()?
> 

panic() uses SDOG_EMERG as a log level. It seems that it is used for
expressing runtime error in other part of sheep. I though the above
case should be distinguished from such a case because it implies a bug
of sheep.

...But it seems that SDOG_EMERG is prioritized higher than SDOG_CRIT,
I'll use panic() in the v2.

Thanks for your pointing,
Hitoshi



More information about the sheepdog mailing list