[sheepdog] [PATCH 1/2] collie: clean signal handler register

Hitoshi Mitake mitake.hitoshi at gmail.com
Sun Feb 24 10:52:01 CET 2013


At Sun, 24 Feb 2013 18:36:35 +0900,
MORITA Kazutaka wrote:
> 
> At Sun, 24 Feb 2013 18:20:08 +0900,
> Hitoshi Mitake wrote:
> > 
> > This patch does 2 trivial cleanings:
> > 1. main() of collie doesn't need sa_old when it calls sigaction() for
> >    registering handler of SIGABRT
> > 2. print string representation of errno in crash_handler(). It should
> >    print the value because abort() can be called with any reasons
> >    other than out of memory.
> > 
> > Cc: Harry Wei <harryxiyou at gmail.com>
> > Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
> > ---
> >  collie/collie.c |    5 ++---
> >  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> Can you wait this one?  I have the similar patch in my local queue
> which cleans up signal handlers too and, in addition, shows a
> backtrace when the program exits unexpectedly.

Sure. Your patch seems to be more suitable than mine because of the
backtrace functionality. Of course I can wait.

Thanks,
Hitoshi



More information about the sheepdog mailing list