[sheepdog] [PATCH 3/3] remove newline from sd_printf format string

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Mon Feb 25 09:57:40 CET 2013


At Mon, 25 Feb 2013 16:41:55 +0800,
Liu Yuan wrote:
> 
> On 02/25/2013 04:31 PM, MORITA Kazutaka wrote:
> >  		ret = pthread_create(&wi->worker_thread, NULL, worker_routine,
> >  				     wi);
> >  		if (ret) {
> > -			sd_eprintf("failed to create worker thread: %s\n",
> > -				strerror(ret));
> > +			sd_eprintf("failed to create worker thread: %m");
> 
> For pthread_create, it returns error number directly and IIRC, errno
> isn't set. So %m always 'Success'.

Oops, I misjudged it with strerror(errno).

I'll split the changes that use %m for strerrror(errno) into another
patch.

Thanks,

Kazutaka



More information about the sheepdog mailing list