[sheepdog] [PATCH 4/4] sheep: dump cluster info when exiting unexpectedly

MORITA Kazutaka morita.kazutaka at gmail.com
Thu Feb 28 09:12:37 CET 2013


At Thu, 28 Feb 2013 16:03:00 +0800,
Liu Yuan wrote:
> 
> On 02/28/2013 01:15 AM, MORITA Kazutaka wrote:
> >  	sd_backtrace();
> > +	sd_dump_variable(__sys);
> 
> Maybe it is better to call sd_dump_varivable() inside sd_backtrace()?

IMHO, no.  Dumping cluster info is unrelated to backtracing.

I think keeping sd_dump_variable as a different function is useful.
When debugging, we can use the function to dump complicated structures
where backtrace is not necessary.

Thanks,

Kazutaka



More information about the sheepdog mailing list