[sheepdog] [PATCH v2] sheep:avoid the OOM killer

[Liu Yuan]

On Fri, Jul 05, 2013 at 03:09:03PM +0900, Hitoshi Mitake wrote:
> At Fri, 5 Jul 2013 14:04:12 +0800,
> Liu Yuan wrote:
> > 
> > On Fri, Jul 05, 2013 at 02:46:52PM +0900, Hitoshi Mitake wrote:
> > > Because sheep provides virtual disks to many VMs, sheep is an
> > > important process and it shouldn't be killed by the OOM killer of
> > > Linux. This patch implements a mechanism for avoiding the OOM killer.
> > > 
> > > Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
> > > ---
> > > 
> > > v2:
> > >  - remove the meaningless comment
> > >  - add a description for the value -1000
> > > 
> > >  sheep/sheep.c |   33 +++++++++++++++++++++++++++++++++
> > >  1 file changed, 33 insertions(+)
> > > 
> > > diff --git a/sheep/sheep.c b/sheep/sheep.c
> > > index 84bd269..335edb4 100644
> > > --- a/sheep/sheep.c
> > > +++ b/sheep/sheep.c
> > > @@ -371,6 +371,35 @@ static int create_work_queues(void)
> > >  	return 0;
> > >  }
> > >  
> > > +static int avoid_oom_killer(void)
> > 
> > I'd suggest name it as more explicitly as disable_oom_killer()
> 
> disable_oom_killer() is not an accurate name, too. Because the
> function doesn't disable OOM killer. How about disable_oom_killing()?

Looks good to me.

Thanks
Yuan