[sheepdog] [PATCH 3/4] sheep: handle block/unblock/notify error

[Liu Yuan]

On Sat, Jul 06, 2013 at 10:31:34AM +0800, Kai Zhang wrote:
> 
> On Jul 6, 2013, at 10:19 AM, Liu Yuan <namei.unix at gmail.com> wrote:
> 
> > You should explain why we need to handle broadcast event failure. Sheep assume
> > they never fail.
> 
> Currently, sheep assume they never fail.
> 
> But actually, they may probably fail and sheep just ignore it.
> 
> I think we should not ignore it.
> 
> For example, for a block operation, if sheep failed to 'BLOCK' it, the following 'UNBLOCK' will
> unblock an improper event.

I think you should explain which function in driver has the possibility to fail
during the events. 'may probably fail' doesn't say anything.

By reading the code, cpg_mcast_joined() and zk_queue_push() might fail in the
broadcast events, so you'd better mention it in the commit log.

Thanks,
Yuan