[sheepdog] [PATCH v2 2/4] util: introduce a new data type refcnt_t for reference counting

[MORITA Kazutaka]

At Tue,  9 Jul 2013 16:42:01 +0900,
Hitoshi Mitake wrote:
> 
> From: Hitoshi Mitake <mitake.hitoshi at gmail.com>
> 
> Using raw int for reference counting directly is dangerous because it
> cannot detect ++ or -- for these counters at compilation time. So this
> patch implements a new data type refcnt_t for safe reference counting
> which can be done by multiple threads in parallel.
> 
> Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
> ---
>  include/util.h |   36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/include/util.h b/include/util.h
> index 1517680..7e60ccc 100644
> --- a/include/util.h
> +++ b/include/util.h
> @@ -212,6 +212,42 @@ static inline void uatomic_set_false(uatomic_bool *val)
>  	(typeof(*(p)))ret;				\
>  })
>  
> +/*
> + * refcnt_t: reference counter which can be manipulated by multiple threads
> + * safely
> + */
> +
> +typedef struct {
> +	int val;
> +} refcnt_t;
> +
> +static inline int refcnt_read(refcnt_t *rc)
> +{
> +	return rc->val;

Use uatomic_read to make refcnt_t thread-safe.

> +}
> +
> +static inline void refcnt_set(refcnt_t *rc, int val)
> +{
> +	rc->val = val;
> +}

Use uatomic_set.

> +
> +static inline void refcnt_inc(refcnt_t *rc)
> +{
> +	uatomic_inc(&rc->val);
> +}
> +
> +static inline void refcnt_dec(refcnt_t *rc)
> +{
> +	uatomic_dec(&rc->val);
> +	assert(0 <= rc->val);
> +}

I'd suggest using uatomic_sub_return in this function and removing
refcnt_dec_return.

Thanks,

Kazutaka