[sheepdog] [PATCH] collie: don't use direct write for 'vdi snapshot'

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Thu Jul 18 09:24:42 CEST 2013


At Thu, 18 Jul 2013 14:33:27 +0800,
Liu Yuan wrote:
> 
> - also remove an unnecessary tag check
> 
> Direct write will ask cache layer to flush_and_delete cache blindly
> (set create = 1), which will be a time consuming process and lead
> 'collie vdi snapshot' easily timeout and cause unexpected behavior thereafter.
> 
> Use non-direct write to be cache friendly. 'collie vdi snapshot' will be boosted
> a lot with cache enabled.
> 
> Signed-off-by: Liu Yuan <namei.unix at gmail.com>
> ---
>  collie/vdi.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Applied, thanks!

Kazutaka



More information about the sheepdog mailing list