[sheepdog] [PATCH v3] sheep: remove master node

[Liu Yuan]

On Wed, Jul 24, 2013 at 04:48:07PM +0900, MORITA Kazutaka wrote:
> At Wed, 24 Jul 2013 15:38:12 +0800,
> Liu Yuan wrote:
> > 
> > On Wed, Jul 24, 2013 at 04:00:33PM +0900, MORITA Kazutaka wrote:
> > > At Tue, 23 Jul 2013 17:23:44 +0800,
> > > Kai Zhang wrote:
> > > > 
> > > > On Jul 23, 2013, at 4:44 PM, MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp> wrote:
> > > > 
> > > > > Should I include my zookeer patch into this series?  You know, my
> > > > > zookeeper patch didn't remove the zk master in either way.  But if you
> > > > > want to do your work onto my patch, I'll include my zk patch again
> > > > > into the v4 series.
> > > > 
> > > > If the patch is an separate one and has been done, I would like to see it in v4 : )
> > > 
> > > Well, the patch was in my v1 series.
> > > 
> > >   http://lists.wpkg.org/pipermail/sheepdog/2013-July/010804.html
> > > 
> > > You will try to completely remove a master from the zk driver, right?
> > > If the change looks okay to you, I'll add it to v4.  If not sure, I
> > > think it's better to keep it out of this series.
> > > 
> > 
> > I think you should keep zk code out of this patch. And write a new patch for it,
> 
> Okay.  I'll update v4 after adding some comments to the code.
> 
> > then Kai can work on top of it. After all problems are sorted out, I'll apply
> > them as a bundle.
> 
> Any reason this patch should be pending until Kai finishes his work?
> I think this patch doesn't introduce any problem.

I think you'd better put comments in the source for why-we-need-check-nr_nodes.

Thanks
Yuan