[sheepdog] [PATCH RFC 0/2] show recovery progress via collie

[Liu Yuan]

On Mon, Jul 29, 2013 at 05:08:17PM +0900, Hitoshi Mitake wrote:
> At Mon, 29 Jul 2013 15:46:57 +0800,
> Liu Yuan wrote:
> > 
> > On Mon, Jul 29, 2013 at 04:39:25PM +0900, Hitoshi Mitake wrote:
> > > Current sheepdog doesn't provide a progress of recovery process. The
> > > information is important when sheepdog cluster stores massive data.
> > > 
> > > This patch implements a mechanism for showing it. A new subcommand
> > > "collie node recovery-progress" prints a progress bar of recovery
> > > process.
> > > 
> > > There are still todos for improving this. Major ones are:
> > > 1. Calculate size of actually copied objects.
> > >    For doing this, not so trivial changes for recovery process is
> > >    required.
> > > 
> > > 2. Print remaining physical time.
> > >    Even if it is not so acculate, it is helpful for administrators.
> > > 
> > > But I think this is useful for sheepdog administrators. I'd like to
> > > hear your comments.
> > > 
> > > Thanks,
> > > 
> > > Hitoshi Mitake (2):
> > >   sheep: enhance STAT_RECOVERY for prividing information of recovery
> > >     progress
> > >   collie: add a new subcommand "recovery-progress" to node
> > 
> > Why you need a new command instead of a option?
> > collie node recovery --verbose looks better
> 
> I agree. How about "collie node recovery --progress"?

Looks okay to me

Thanks
Yuan