[sheepdog] [PATCH] zookeeper: exit program on unrecoverable error
Liu Yuan
namei.unix at gmail.com
Fri Jun 7 09:32:01 CEST 2013
On 06/07/2013 03:20 PM, MORITA Kazutaka wrote:
> At Fri, 7 Jun 2013 14:08:59 +0900,
> MORITA Kazutaka wrote:
>>
>> -static inline ZOOAPI int zk_delete_node(const char *path, int version)
>> +static inline void zk_delete_node(const char *path, int version)
>> {
>> int rc;
>> do {
>> rc = zoo_delete(zhandle, path, version);
>> } while (rc == ZOPERATIONTIMEOUT || rc == ZCONNECTIONLOSS);
>> +
>> if (rc != ZOK)
>> - sd_eprintf("failed, path:%s, %s", path, zerror(rc));
>> - return rc;
>> + panic("failed, path:%s, %s", path, zerror(rc));
>> }
>
> I got a ZNONODE error with tests/052. Is it an expected return value
> for us?
>
> Thanks,
>
> Kazutaka
>
I think it is okay for zk_delete_node return ZNONODE.
Thanks,
Yuan
More information about the sheepdog
mailing list