[sheepdog] [PATCH v2] zookeeper: exit program on unrecoverable error

[Kai Zhang]

On Jun 12, 2013, at 7:35 PM, MORITA Kazutaka <morita.kazutaka at gmail.com> wrote:

> Well, why is it better?  Is it easier to rebase my patch onto yours?
> My patch fixes a critical problem that epoch information will be
> corrupted after session timeout.  Currently, there is no way to fix
> the broken epoch other than re-formatting the cluster.
> 

Sorry, I didn't get that this path will fix the epoch broken issue.
What I said "better" is based on this patch does not fix any critical issue.
Could you explain some details on this? 
And I guess this is caused by the concurrent start up. But I'm not quite sure.

> If you could review my patch and add your Reviewed-by tag, I would
> apply this patch asap.  Yuan is offline this week, so reviews from
> other developers are highly appreciated.  But if there is a reason
> your patch should be applied first, I'll wait for your patch. :)

I'm very happy to review this patch.

Thanks,
Kyle
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wpkg.org/pipermail/sheepdog/attachments/20130612/b1b72682/attachment-0004.html>