[sheepdog] [PATCH v2] zookeeper: exit program on unrecoverable error

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Mon Jun 17 07:52:39 CEST 2013


At Mon, 17 Jun 2013 13:26:31 +0800,
Kai Zhang wrote:
> 
> On Jun 17, 2013, at 11:42 AM, MORITA Kazutaka <morita.kazutaka at gmail.com> wrote:
> 
> > If zk_queue_peek() returns false, zk_event_handler() can call
> > kick_block_event() and sd_block_handler() can be called before any
> > other zk operations?
> 
> I see.
> You are right, we should panic out currently.
> However, I think the ideal way is to wait until reconnected and clean the blocked events.
> Is that right?

Yes, my patch is just a workaround.  If your series fixes all the
session timeout problems, I guess my patch is almost unnecessary.
(Sorry, I've not seen the details of your series yet.)

Thanks,

Kazutaka



More information about the sheepdog mailing list