[sheepdog] Jenkins for sheepdog project

[Joseph Glanville]

On Sun, Jun 16, 2013 at 6:52 PM, Wenhao Xu <wenhao at zelin.io> wrote:
> Hi Joseph,
>
> Thanks for the proposal. Integrating Gerrit (and other ticket systems) into
> the review process has been discussed several times. However, the mail list
> has been working well for sheepdog for a long time. And we don't see
> sticking to maillist for bug reporting and code review is a bad idea at the
> current stage.
>
> But I think the community is still open to Gerrit if it could improve the
> review process a lot more in the future, e.g. when we have more developers.
>
>
> FYI, Paste some old arguments from our awesome developers on the maillist
> about Gerrit:

I don't want to start and argument but I think it's worth debunking
some of these.

> "
> I have some awful experience of Gerrit system, it just looks to me
> lifting higher barrier and throwing more problems than it solves:
>
>  1 the review process in hidden in the Gerrit and not as open as current
> plain patch in the mailing list

You can have gerrit post the patchsets to the mailing list. You can
also then discuss them and emails will appear as comments in the
gerrit system. This can be annoying to setup but it definitely works.

>  2 need more steps of submitting the patch set than current only 'git
> send-email' one liner.

When you have your changeset simply type git review, this will
automatically create a review and trigger any hooks on the gerrit side
like triggering a jenkins build and emailing the patchset to the
mailing list.

>  3 the patch set and its history isn't indexable or logged by other
> system like marc.info

As already noted you can do some of this by mailing patchsets to the
list, that aside gerrit is very indexable as can be seen if you try
search for openstack or android changes.

>  4 It is very cumbersome than plain mail text.

I disagree because now that patchsets are stored as git refs in the
remote repository which is very easy to work with.
But this is a matter of opinion. :)

> "
> "
> IMHO, Gerrit is too complex to review patches.
> When I contributed a patch to OpenStack, I thought that Gerrit was a
> barrier for new developers to join community.  However, if I'm in a
> minority group, I'm not against introducing it.
> "
> ...
>
>
> Sheepdog is compatible with openstack anyway, even when we have two
> different review systems, don't we? ;)

Hehe there is more to compatibility than the code working together. :P

As the test suite becomes more fully fledged the importance of making
use of it increases. Having a proper CI system like this will ensure
tests are run against every patchset.

>
>
> Regards,
> Wenhao
>
>
>
>
> On Mon, Jun 17, 2013 at 9:19 AM, Joseph Glanville <joseph at cloudscaling.com>
> wrote:
>>
>> How do people feel about integrating Gerrit at some stage for code review?
>>
>> If Sheepdog wants to be closer aligned with OpenStack this would be a
>> great way of making the 2 ecosystems more compatible. :)
>>
>> On Sun, Jun 16, 2013 at 5:13 PM, MORITA Kazutaka
>> <morita.kazutaka at gmail.com> wrote:
>> > At Fri, 14 Jun 2013 11:44:25 +0800,
>> > Kai Zhang wrote:
>> >>
>> >> Hi all
>> >>
>> >> I'm very happy to announce that a public Jenkins server for sheepdog
>> >> has been set up.
>> >> Both server and hostname are sponsored by zelin.io
>> >>
>> >> Please check http://jenkins.sheepdog-project.org for more.
>> >
>> > Great, thanks a lot!
>> >
>> >>
>> >> Currently, there are only 2 jobs.
>> >> One is for daily build. The other is for testing with local driver.
>> >> (This is a downstream job of former one)
>> >>
>> >> However, it is still far from enough.
>> >> The fowling things will be done soon:
>> >> - add github hook so that each commit will trigger a new build
>> >> - generate graphical testing report
>> >> - add jobs for testing zookeeper and corosync
>> >> - fix testing errors
>> >>
>> >> For security reason, only login user can configure jobs and sign up has
>> >> been disabled.
>> >> It would be very appreciated if you would like to contribute on
>> >> Jenkins. And I will create an account for you.
>> >
>> > Can you create an account for me?  I'd be happy to help you.
>> >
>> > Thanks,
>> >
>> > Kazutaka
>> > --
>> > sheepdog mailing list
>> > sheepdog at lists.wpkg.org
>> > http://lists.wpkg.org/mailman/listinfo/sheepdog
>> --
>> sheepdog mailing list
>> sheepdog at lists.wpkg.org
>> http://lists.wpkg.org/mailman/listinfo/sheepdog
>
>